Skip to content

✨ Add support for custom webhook paths #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ Add support for custom webhook paths #5171

wants to merge 1 commit into from
+1,466 −30

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Nov 2, 2025 •
edited
Loading

Users can now set custom paths for webhooks using --defaulting-path and --validation-path flags. Requires controller-runtime v0.21+.

Closes: #4295

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2025
@camilamacedo86 camilamacedo86 force-pushed the custom-webhok-path branch 2 times, most recently from 509ce87 to 6f034cb Compare November 2, 2025 17:55
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Nov 2, 2025 •
edited
Loading

Hey @damsien

Could you please give a hand in this one?
Since you request it I think you will be the best one to help us with reviews :-)
WDYT?

@camilamacedo86 camilamacedo86 force-pushed the custom-webhok-path branch 2 times, most recently from cc396a5 to 7aeaee9 Compare November 2, 2025 20:05
@camilamacedo86
Copy link
Member Author

c/c @sbueringer

@camilamacedo86
Add support for custom webhook paths
767d0db 
Users can now set custom paths for webhooks using --defaulting-path and
--validation-path flags. Requires controller-runtime v0.20+.

Assisted-by: Cursor
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-34-0

@damsien
Copy link
Contributor

damsien commented Nov 3, 2025 •
edited
Loading

Hello @camilamacedo86 , thanks for reaching me!

I tested your implementation and it works well! However, I noticed that you didn't implemented an regex checker for the path. I don't know if it is supposed to not being implemented.

If we need to add the regex validation, I would like to contribute to your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom path for webhooks

3 participants

@camilamacedo86 @k8s-ci-robot @damsien